Conversation
…ng and clean-up for DRY results required. CacioCavallo removed in favour of existing CI Headless solution. Signed-off-by: Nick Boyd <nick.boyd@itextpdf.com>
Signed-off-by: Nick Boyd <nick.boyd@itextpdf.com>
Signed-off-by: Nick Boyd <nick.boyd@itextpdf.com>
Fixed Plugin Version issues Added java.awt and sun.awt paths to the reflection opening rules during testing. Signed-off-by: Nick Boyd <nick.boyd@itextpdf.com>
…efault constructor to Undo/Redo Test class. Signed-off-by: Nick Boyd <nick.boyd@itextpdf.com>
michaeldemey
reviewed
Jun 7, 2023
michaeldemey
reviewed
Jun 7, 2023
| /** | ||
| * @see java.util.Observer#update(java.util.Observable, java.lang.Object) | ||
| */ | ||
| // TODO: Work out why the PDF Object appears to be updated before it even gets to this point... |
Contributor
There was a problem hiding this comment.
Is this still relevant?
michaeldemey
reviewed
Jun 7, 2023
| public int addTreeNodeDictChild(PdfObjectTreeNode parent, PdfName key, int index) { | ||
| PdfObjectTreeNode child = PdfObjectTreeNode.getInstance((PdfDictionary) parent.getPdfObject(), key); | ||
| public int addTreeNodeDictChild(PdfObjectTreeNode parent, PdfName key, int index, PdfObject childValue) { | ||
| // PdfObjectTreeNode child = PdfObjectTreeNode.getInstance((PdfDictionary) parent.getPdfObject(), key); |
Contributor
There was a problem hiding this comment.
Remove commented out lines. They are tracked in git history
michaeldemey
reviewed
Jun 7, 2023
| }else if(parent.isArray()){ | ||
| // TODO: Is the TreeNode driven by the PdfObject or visa versa? | ||
| // TreeNode drives the Object, but Object determines the table view... | ||
| PdfArray parentArray = (PdfArray)parent.getPdfObject(); |
Contributor
There was a problem hiding this comment.
This doesn't do anything?
Leftover memos, already fixed.
Signed-off-by: Nick Boyd <nick.boyd@itextpdf.com>
|
Apologies for the Force-Push forgot to squash before push. |
Minothor
reviewed
Jun 8, 2023
| } | ||
|
|
||
| private void extractEditData(RupsEvent editEvent) { | ||
| // TODO: Maybe we can add some granularity to these events? |
There was a problem hiding this comment.
@michaeldemey is this ToDo worth keeping in for future brainstorming or best removed for cleanliless?
Signed-off-by: Nick Boyd <nick.boyd@itextpdf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Programmatically created Pull Request to automatically keep merge branch to develop up-to-date