Eliminate single element tuple-like from user-facing API#42
Open
Eliminate single element tuple-like from user-facing API#42
Conversation
yaito3014
force-pushed
the
eliminate-one-size-tuple
branch
from
a4ace3a to
b0533fb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
saki7
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
yaito3014
force-pushed
the
eliminate-one-size-tuple
branch
from
c475655 to
0e62b8a
Compare
saki7
reviewed
Feb 19, 2026
saki7
reviewed
Feb 19, 2026
include/iris/x4/core/move_to.hpp
Outdated
| template<traits::NonUnusedAttr Source, traits::CategorizedAttr<traits::variant_attr> Dest> | ||
| requires (!traits::is_size_one_sequence_v<Source>) | ||
| requires | ||
| // traits::variant_has_substitute_v<Dest, Source> && // TODO: investigate compilation error due to existance of this constraint |
saki7
reviewed
Feb 24, 2026
saki7
reviewed
Feb 24, 2026
yaito3014
force-pushed
the
eliminate-one-size-tuple
branch
from
bf0651a to
3556902
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18
Todo
var = ident >> epsvar = as<Ident>(ident)var = identlexeme[alpha >> *alnum]gets resolved into wrong overload ofparse_sequencethat expects fusion sequence with mismatched number of elements boostorg/spirit_x4#27 is related to this PR and it must be included in the new unit test