IBX-10708: Introduced SerializerFactory and improve serializer config #689
+88
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Dec 16, 2025
konradoboza
approved these changes
Dec 16, 2025
konradoboza
reviewed
Dec 17, 2025
Steveb-p
reviewed
Dec 17, 2025
added 3 commits
December 22, 2025 12:03
Implemented `SerializerFactory` to streamline serializer creation logic. Updated services configuration to use tagged normalizers and encoders, improving modularity and maintainability. Added `SiteAccessMatcherDenormalizer` with corresponding service definitions.
…g redundant `Traversable` checks and improving property encapsulation.
tomaszszopinski
force-pushed
the
IBX-10708-fixed-data-denormalization
branch
from
c6e0e8f to
102f43b
Compare
|
tomaszszopinski
approved these changes
Jan 7, 2026
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on Ibexa DXP v5 apache&ddev.
alongosz
approved these changes
Jan 7, 2026
Member
alongosz
left a comment
alongosz
left a comment
There was a problem hiding this comment.
This overall lacks some container-level testing (using e.g., Matthias' Symfony DI testing library). However coming a bit late to the party and I see there's some Behat coverage elesewhere, so +1.
Comment on lines
+79
to
+80
| # Warning: Do NOT enable autoconfigure for Serializer and Normalizer services. | ||
| # They will be tagged with "serializer.normalizer" tag and injected to main app serializer service if done so. |
Member
There was a problem hiding this comment.
This should be checked via container tests. It's easy to add _defaults on top of the file and miss that comment ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
https://github.com/ibexa/site-factory/pull/148
Description:
Implemented
SerializerFactoryto streamline serializer creation logic. Updated services configuration to use tagged normalizers and encoders, improving modularity and maintainability. AddedSiteAccessMatcherDenormalizerwith corresponding service definitions.For QA:
Regresssion: ibexa/commerce#1632
Documentation: