Skip to content

fix: fireModelEvent comparison in Pivot delete methods (PHPStan error) #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertcht merged 1 commit into from
Jan 5, 2026
Merged

fix: fireModelEvent comparison in Pivot delete methods (PHPStan error) #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/core/src/Database/Eloquent/Relations/MorphPivot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Hypervel\Database\Eloquent\Concerns\HasAttributes;
use Hypervel\Database\Eloquent\Concerns\HasCallbacks;
use Hypervel\Database\Eloquent\Concerns\HasObservers;
use Psr\EventDispatcher\StoppableEventInterface;

class MorphPivot extends BaseMorphPivot
{
Expand All @@ -29,8 +30,10 @@ public function delete(): mixed
}

// For composite key pivots, manually fire events around the raw delete
if ($this->fireModelEvent('deleting') === false) {
return 0;
if ($event = $this->fireModelEvent('deleting')) {
if ($event instanceof StoppableEventInterface && $event->isPropagationStopped()) {
return 0;
}
}

$query = $this->getDeleteQuery();
Expand Down
7 changes: 5 additions & 2 deletions src/core/src/Database/Eloquent/Relations/Pivot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Hypervel\Database\Eloquent\Concerns\HasAttributes;
use Hypervel\Database\Eloquent\Concerns\HasCallbacks;
use Hypervel\Database\Eloquent\Concerns\HasObservers;
use Psr\EventDispatcher\StoppableEventInterface;

class Pivot extends BasePivot
{
Expand All @@ -28,8 +29,10 @@ public function delete(): mixed
}

// For composite key pivots, manually fire events around the raw delete
if ($this->fireModelEvent('deleting') === false) {
return 0;
if ($event = $this->fireModelEvent('deleting')) {
if ($event instanceof StoppableEventInterface && $event->isPropagationStopped()) {
return 0;
}
}

$result = $this->getDeleteQuery()->delete();
Expand Down