Refactor containers h includes#1176
Conversation
|
Thanks for the PR, I'm taking a look but I would like to know, were LLMs were involved in this? |
|
Thank you for your confirmation. Regarding Regarding C++ pragmas, I first checked each file for the presence of Additionally, when drafting the PR description, I used an LLM to translate from Japanese to English. If there are any errors or omissions, please provide guidance. |
|
Thanks, I don't mind if you use an LLM for translation. |
meooow25
left a comment
There was a problem hiding this comment.
I think map-strictness.hs could also do without the {-# LANGUAGE CPP #-}, would you please add that to the PR?
Also, it needs a rebase to avoid conflicts.
Overview
Removed unnecessary CPP and C header includes.
Correction details
C header removal
The following modules use values defined in
containers.h:Removed
#include "containers.h"from all other modules.CPP removal
Removed CPP language pragmas from files that do not use CPP directives.
Testing
cabal build containerssucceedscabal test containers-testspasses all testscabal bench containers-testspasses all benchmarksWhile the changes are straightforward, they affect a wide range of files, so careful review is requested.
Fixes #968