Use spec.creationTime consistently for reply timestamps#207
Merged
f2c-ci-robot[bot] merged 2 commits intomainfrom Jan 19, 2026
Merged
Use spec.creationTime consistently for reply timestamps#207f2c-ci-robot[bot] merged 2 commits intomainfrom
f2c-ci-robot[bot] merged 2 commits intomainfrom
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: ruibaby <21301288+ruibaby@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix reply time inconsistency with comment time
Use spec.creationTime consistently for reply timestamps
Jan 19, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replies used
metadata.creationTimestampwhile comments usedspec.creationTime. Sincemetadata.creationTimestampdoesn't necessarily represent the actual creation time, both should usespec.creationTime.Changes:
reply-item.tsline 122 to usereply?.spec.creationTimeinstead ofreply?.metadata.creationTimestampThis aligns replies with comments, which already use
spec.creationTime.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
pkg.pr.new/usr/local/bin/node node /usr/local/bin/pnpm install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.