Skip to content

Conversation

@KSamra
Copy link
Member

@KSamra KSamra commented Jan 18, 2026

Fixes #8329

What changes did you make?

  • Added an entry for another member on the page /projects/website

Why did you make the changes (we will use this info to test)?

  • to keep project information up to date so that visitors to the website can find accurate information

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b KSamra-update-project-profile-8329 gh-pages
git pull https://github.com/KSamra/website.git update-project-profile-8329

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 18, 2026
@abinetabate1 abinetabate1 self-requested a review January 18, 2026 18:08
@abinetabate1
Copy link
Member

Review ETA: 6 PM 1/18/22
Availability: 10 AM - 12 PM (1/18/22)

Copy link
Member

@abinetabate1 abinetabate1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Minor Nit Pick --> Please check CodeQL Alerts checkbox (i.e. "I have checked this PR for CodeQL alerts and none were found.")

@KSamra
Copy link
Member Author

KSamra commented Jan 18, 2026

Looks good.

Minor Nit Pick --> Please check CodeQL Alerts checkbox (i.e. "I have checked this PR for CodeQL alerts and none were found.")

Done, thank you for the review :)

Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KSamra everything looks good. Code changes, branches and screenshots. As issues become more complex the What and Why sections become more important for reviewers, good job there too.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jan 18, 2026
@daras-cu
Copy link
Member

Hi @KSamra, good work on this issue. For the future, you should make your PR title and description a little more specific by mentioning the specific member you added. There are often issues to add or remove team members so it helps to differentiate them.

@daras-cu daras-cu merged commit 3a77990 into hackforla:gh-pages Jan 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: HackforLA Website Add Donovan Vernon

4 participants