Skip to content

Conversation

@Luke-Oldenburg
Copy link
Contributor

@Luke-Oldenburg Luke-Oldenburg commented Dec 7, 2025

  • fix capitalization
  • add rails uniqueness validation
  • mention slug is optional in ui
  • make slug nullable (default it to the hashid in an after_create_commit callback). This allows for us to totally eliminate the value method and searching by slug || hashid now that the hashid is stored in the slug
  • fix bug where custom slugs dont get passed in the redirect for non-signed in users

@Luke-Oldenburg Luke-Oldenburg requested a review from a team December 7, 2025 02:44
@Luke-Oldenburg Luke-Oldenburg marked this pull request as draft December 7, 2025 02:50
@Luke-Oldenburg Luke-Oldenburg marked this pull request as ready for review December 8, 2025 06:21
@garyhtou garyhtou enabled auto-merge December 10, 2025 19:57
@garyhtou garyhtou added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 03d78ec Dec 10, 2025
16 checks passed
@garyhtou garyhtou deleted the lro-referral-link-improvements-12062025 branch December 10, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants