A108: OpenTelemetry Custom Per-Call Metric Label#525
A108: OpenTelemetry Custom Per-Call Metric Label#525ejona86 wants to merge 3 commits intogrpc:masterfrom
Conversation
|
|
||
| ### Go | ||
|
|
||
| gRPC Go will add a new API to set and get the custom label value in |
|
|
||
| ### C++ | ||
|
|
||
| gRPC C++ will add an API to ClientContext. Precise details TBD. |
There was a problem hiding this comment.
@markdroth, can you help me flesh this out? It looks like y'all will need specialized APIs/plumbing.
There was a problem hiding this comment.
I'll chat with @ctiller after the holidays to flesh this out, and I'll get back to you.
|
CC @ctiller |
| * `grpc.client.call.retry_delay` | ||
| * Other per-call instruments, e.g., those added by an LB policy, are encouraged | ||
| to support this label | ||
| * RLS is the only such case today, but is not defined in a gRFC |
There was a problem hiding this comment.
I'd suggest just removing this bullet, since it isn't actually a public API. If we want this label on these metrics, we can figure that out internally.
There was a problem hiding this comment.
Unless there is a strong objection, I'm going to leave it, because "figure it out internally" has not been going well, and I basically need to define nothing here. And the code is OSS and I made all the changes to Java in the same commit.
Without this bullet, I'd also need to say "there are no such cases today" to be clear I'm giving the exhaustive list, but that comment would be incorrect because RLS does exist.
|
|
||
| ### C++ | ||
|
|
||
| gRPC C++ will add an API to ClientContext. Precise details TBD. |
There was a problem hiding this comment.
I'll chat with @ctiller after the holidays to flesh this out, and I'll get back to you.
|
@markdroth, @easwars, @dfawley, friendly ping for review. |
2 participants
No description provided.