Add base commit cache preference to restore keys #803
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on PR or push events, prefer cache entries from the base commit (PR base branch) or previous commit (push before SHA) over generic fallbacks. This improves cache hit rates for incremental builds. Restore key hierarchy is now: 1. Exact SHA match 2. Same job+matrix (any SHA) 3. Same job+matrix with base/previous commit SHA (NEW) 4. Same job (any matrix) 5. Same OS/environment Signed-off-by: Andre Kurait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running on PR or push events, prefer cache entries from the base commit (PR base branch) or previous commit (push before SHA) over generic fallbacks. This improves cache hit rates for incremental builds.
Changes
Modified
sources/src/caching/cache-key.tsto add a new restore key that targets the base/previous commit SHA.Restore key hierarchy is now:
Event Support
pull_request/pull_request_target: Usespayload.pull_request.base.shapush: Usespayload.before(skips Git null SHA for new branches)Rationale
For PR workflows, the cache from the base branch is often more relevant than a random previous run. This change prioritizes that cache entry while maintaining backward compatibility with the existing fallback chain.