-
Notifications
You must be signed in to change notification settings - Fork 86
chore: remove 3.9 from kokoro tests #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's continuous integration configuration by removing Python 3.9 from the default Kokoro test suite. This change aligns the testing setup with the updated Kokoro base image, which no longer includes Python 3.9, thereby streamlining the CI process. Python 3.9 test coverage is maintained through existing GitHub Actions workflows. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes Python 3.9 from the default Kokoro test sessions by updating nox.options.sessions. The change is correct and achieves the stated goal. I have added one suggestion to improve the maintainability of the session list by generating it programmatically, which would make future updates easier.
| nox.options.sessions = [ | ||
| "unit-3.9", | ||
| "unit-3.10", | ||
| "unit-3.11", | ||
| "unit-3.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability, consider generating the list of unit test sessions programmatically instead of maintaining it manually. This would make it easier to update the versions tested in Kokoro in the future by changing them in a single place.
For example:
# Python versions to test in Kokoro CI.
KOKORO_PYTHON_VERSIONS = ["3.10", "3.11", "3.12", "3.13", "3.14"]
nox.options.sessions = [f"unit-{version}" for version in KOKORO_PYTHON_VERSIONS] + [
"system_emulated",
"system",
"mypy",
"cover",
"lint",
"lint_setup_py",
"blacken",
"docs",
"docfx",
"format",
]
chalmerlowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3.9 has been removed from the kokoro base image, so we should remove the tests from our configs
3.9 is still tested in GitHub Actions