Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

3.9 has been removed from the kokoro base image, so we should remove the tests from our configs

3.9 is still tested in GitHub Actions

@daniel-sanche daniel-sanche requested review from a team as code owners February 11, 2026 22:31
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Feb 11, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's continuous integration configuration by removing Python 3.9 from the default Kokoro test suite. This change aligns the testing setup with the updated Kokoro base image, which no longer includes Python 3.9, thereby streamlining the CI process. Python 3.9 test coverage is maintained through existing GitHub Actions workflows.

Highlights

  • Kokoro Test Configuration: Removed Python 3.9 from the default Kokoro test sessions in noxfile.py.
  • Python 3.9 Support: Confirmed that Python 3.9 is still tested in GitHub Actions, ensuring continued coverage despite its removal from Kokoro.
Changelog
  • noxfile.py
    • Removed 'unit-3.9' from the list of default Nox sessions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes Python 3.9 from the default Kokoro test sessions by updating nox.options.sessions. The change is correct and achieves the stated goal. I have added one suggestion to improve the maintainability of the session list by generating it programmatically, which would make future updates easier.

Comment on lines 87 to 90
nox.options.sessions = [
"unit-3.9",
"unit-3.10",
"unit-3.11",
"unit-3.12",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, consider generating the list of unit test sessions programmatically instead of maintaining it manually. This would make it easier to update the versions tested in Kokoro in the future by changing them in a single place.

For example:

# Python versions to test in Kokoro CI.
KOKORO_PYTHON_VERSIONS = ["3.10", "3.11", "3.12", "3.13", "3.14"]

nox.options.sessions = [f"unit-{version}" for version in KOKORO_PYTHON_VERSIONS] + [
    "system_emulated",
    "system",
    "mypy",
    "cover",
    "lint",
    "lint_setup_py",
    "blacken",
    "docs",
    "docfx",
    "format",
]

Copy link

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche merged commit 63f91d7 into main Feb 12, 2026
25 checks passed
@daniel-sanche daniel-sanche deleted the remove_39 branch February 12, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants