Skip to content

chore: remove pin for types-protobuf to support 3.14 #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ohmayr wants to merge 1 commit into from
+1 −1
Closed

chore: remove pin for types-protobuf to support 3.14 #2544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ def mypy(session):
# Pin to click==8.1.3 to workaround https://github.com/pallets/click/issues/2558
session.install(
"mypy",
"types-protobuf<=3.19.7",
"types-protobuf",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the pin is necessary, it's good practice to document why a dependency is unpinned, especially when it was pinned before. This provides context for future maintainers. An inline comment would be a great addition here.

Suggested change
"types-protobuf",
"types-protobuf", # Unpinned to support Python 3.14+

"types-PyYAML",
"types-dataclasses",
"click==8.1.3",
Expand Down
Loading