Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jan 28, 2026

This is required to support running mypy with the latest version of Python i.e. 3.14

@ohmayr ohmayr requested a review from a team as a code owner January 28, 2026 01:50
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates a dependency specification to resolve a compatibility issue, enabling the mypy type checker to function correctly with Python 3.14. By removing a specific version pin, the project can now leverage newer versions of a type-related package, ensuring broader compatibility and support for modern Python environments.

Highlights

  • Dependency Update: The version pin for types-protobuf has been removed from <=3.19.7 to allow for newer versions.
  • Python 3.14 Compatibility: This change is essential to ensure mypy can run correctly with the latest Python version, 3.14.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the version pin for types-protobuf to support Python 3.14. The change is logical, but to improve future maintainability, I've suggested adding an inline comment to document the reason for unpinning this dependency. This provides helpful context for other developers.

session.install(
"mypy",
"types-protobuf<=3.19.7",
"types-protobuf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the pin is necessary, it's good practice to document why a dependency is unpinned, especially when it was pinned before. This provides context for future maintainers. An inline comment would be a great addition here.

Suggested change
"types-protobuf",
"types-protobuf", # Unpinned to support Python 3.14+

@ohmayr ohmayr closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants