-
Notifications
You must be signed in to change notification settings - Fork 77
fix: fix mypy for services with extended operations methods #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a mypy error (Name "Any" is not defined) that occurs for services with extended operations methods. The fix involves conditionally importing Any from the typing module only when service.any_extended_operations_methods is true, which is also the condition for Any being used in the template. This is a clean and correct solution that not only fixes the bug but also avoids potential unused import warnings in services without extended operations. The change is well-targeted and looks good.
This PR fixes the following issue when running
mypyforgoogle-cloud-computeandgoogle-cloud-compute-v1betawhere we seeerror: Name "Any" is not defined [name-defined]when running mypySee follow up issue to improve the golden files where the
mypypresubmit is run on generated code.: #2535See follow up bug for pre-release failure: googleapis/proto-plus-python#558