Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 23, 2026

This PR fixes the following issue when running mypy for google-cloud-compute and google-cloud-compute-v1beta where we see error: Name "Any" is not defined [name-defined] when running mypy

See follow up issue to improve the golden files where the mypy presubmit is run on generated code.: #2535
See follow up bug for pre-release failure: googleapis/proto-plus-python#558

@parthea parthea requested a review from a team as a code owner January 23, 2026 22:28
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 23, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves a mypy type-checking error that arose in generated Python client libraries, specifically for services that incorporate extended operations methods. The fix ensures that the necessary typing.Any import is present only when required, thereby maintaining type-hinting correctness and allowing the generated code to pass static analysis without errors.

Highlights

  • Mypy Error Resolution: Fixed Name "Any" is not defined mypy errors that occurred in generated client libraries for services like google-cloud-compute and google-cloud-compute-v1beta.
  • Conditional Typing Import: Implemented a conditional import for typing.Any within the base.py.j2 template. This ensures Any is only imported when a service utilizes extended operations methods, preventing unnecessary imports and resolving mypy issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a mypy error (Name "Any" is not defined) that occurs for services with extended operations methods. The fix involves conditionally importing Any from the typing module only when service.any_extended_operations_methods is true, which is also the condition for Any being used in the template. This is a clean and correct solution that not only fixes the bug but also avoids potential unused import warnings in services without extended operations. The change is well-targeted and looks good.

@parthea parthea enabled auto-merge (squash) January 23, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants