Improve controller initialization error messages with actionable hints #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpconanfan
reviewed
Dec 27, 2025
| except Exception as e: | ||
| msg = ( | ||
| f'Failed to initialize objects for controller "{module_config_name}". ' | ||
| 'Check if the device is connected and the config is correct.' |
Collaborator
There was a problem hiding this comment.
a controller can be anything, so we intentionally didn't say "device" in the error message.
and we should not have Android specific logic in the generic controller manager module.
I'm rejecting this PR
Collaborator
|
A controller can be anything, so we intentionally didn't say "device" in the error message. Hence I'm rejecting this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Configuration:
Tested with a malformed AndroidDevice configuration in YAML.
Expected Output:
Successfully verified that the hint "Ensure 'adb devices' shows your device" is displayed instead of a raw traceback.