UnusedException: consistent with UnnamedVariable#5459
Closed
commonquail wants to merge 1 commit intogoogle:masterfrom
Closed
UnusedException: consistent with UnnamedVariable#5459commonquail wants to merge 1 commit intogoogle:masterfrom
commonquail wants to merge 1 commit intogoogle:masterfrom
Conversation
A false positive `UnusedException` can be suppressed by naming the caught exception `/unused.*/`. `UnnamedVariable`, in the meantime, wants deliberately unused variables to be unnamed with the Java 22 `_` character, putting the two checks at odds. Teach `UnusedException` to also accept `_` as a suppression mechanism.
cushon
approved these changes
Jan 28, 2026
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
A false positive [`UnusedException`](https://errorprone.info/bugpattern/UnusedException) can be suppressed by naming the caught exception `/unused.*/`. The recently added [`UnnamedVariable`](https://errorprone.info/bugpattern/UnnamedVariable), in the meantime, wants deliberately unused variables to be unnamed with the Java 22 `_` character, putting the two checks at odds. Teach `UnusedException` to also accept `_` as a suppression mechanism. Fixes #5459 FUTURE_COPYBARA_INTEGRATE_REVIEW=#5459 from commonquail:unusedex-unnamed ac5edf7 PiperOrigin-RevId: 862220456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A false positive
UnusedExceptioncan be suppressed by naming the caught exception/unused.*/. The recently addedUnnamedVariable, in the meantime, wants deliberately unused variables to be unnamed with the Java 22_character, putting the two checks at odds. TeachUnusedExceptionto also accept_as a suppression mechanism.