-
Notifications
You must be signed in to change notification settings - Fork 16
β‘ Optimize evalPopulationStdDevDecimal using Welford's algorithm #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
β‘ Optimize evalPopulationStdDevDecimal using Welford's algorithm #157
Conversation
Co-authored-by: suyashkumar <[email protected]>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Can't seem to change this to draft, but no need for review yet, will go over a few of these to verify things first. |
Understood. I will stand by for your verification. |
Co-authored-by: suyashkumar <[email protected]>
| @@ -0,0 +1,49 @@ | |||
| package enginetests | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the Apache 2.0 copyright block at the top of any new files, you can find this in other files in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the Apache 2.0 copyright block.
Co-authored-by: suyashkumar <[email protected]>
|
Overall LGTM. Just curious, but does Jules have an option for squashing commits we could use in the future? |
π‘ What: Replaced the multi-pass implementation of Population Standard Deviation for Decimals with a single-pass Welford's algorithm.
π― Why: The previous implementation iterated over the list multiple times (Count, Avg, then Variance calculation), leading to O(3N) complexity. The new implementation is O(N) and single-pass, which is more efficient for large lists.
π Measured Improvement:
Also added comprehensive tests for
PopulationStdDevcovering edge cases.PR created automatically by Jules for task 16765708447522369412 started by @suyashkumar