#140 add support for intervals on ProperlyIncludesIn#141
Open
vfrank66 wants to merge 1 commit intogoogle:mainfrom
Open
#140 add support for intervals on ProperlyIncludesIn#141vfrank66 wants to merge 1 commit intogoogle:mainfrom
vfrank66 wants to merge 1 commit intogoogle:mainfrom
Conversation
evan-gordon
reviewed
Sep 12, 2025
Collaborator
evan-gordon
left a comment
evan-gordon
left a comment
There was a problem hiding this comment.
Overall looks good! Mostly just a few cosmetic comments.
| var includedIn bool | ||
|
|
||
| // Handle null bounds | ||
| if result.IsNull(leftStart) || result.IsNull(leftEnd) || result.IsNull(rightStart) || result.IsNull(rightEnd) { |
Collaborator
There was a problem hiding this comment.
Wouldn't this not work in the case of Intverval(null, 1] and Interval[5, null) where we can definitively say that one is not included in the other? Consider adding a test for this sort of a case.
|
|
||
| includedIn = (startComp == leftBeforeRight || startComp == leftEqualRight) && | ||
| (endComp == leftBeforeRight || endComp == leftEqualRight) | ||
| } else { |
Collaborator
There was a problem hiding this comment.
I think we could use a helper method similar to
cql/interpreter/operator_arithmetic.go
Line 321 in 25fd8b5
| } | ||
|
|
||
| // Check units match | ||
| if leftStartQty.Unit != rightStartQty.Unit || leftEndQty.Unit != rightEndQty.Unit { |
Collaborator
There was a problem hiding this comment.
mind using the ucum lib here? that should rather easily allow for handling this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.