Fix audience and scopes when using WIF and non-default universes.#522
Open
juliocc wants to merge 1 commit intogoogle-github-actions:mainfrom
Open
Fix audience and scopes when using WIF and non-default universes.#522juliocc wants to merge 1 commit intogoogle-github-actions:mainfrom
juliocc wants to merge 1 commit intogoogle-github-actions:mainfrom
Conversation
R2wenD2
reviewed
Feb 4, 2026
| grantType: `urn:ietf:params:oauth:grant-type:token-exchange`, | ||
| requestedTokenType: `urn:ietf:params:oauth:token-type:access_token`, | ||
| scope: `${this._endpoints.www}/auth/cloud-platform`, | ||
| scope: `https://www.googleapis.com/auth/cloud-platform`, |
There was a problem hiding this comment.
Why this change? this._enpoints.www takes the universe into consideration.
R2wenD2
reviewed
Feb 4, 2026
R2wenD2
left a comment
R2wenD2
left a comment
There was a problem hiding this comment.
I have one question about the scope change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #521