Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 20, 2025

  • Replace fomantic form CSS with custom module
  • Moved code in form.css to modules/form.css, removed around 70% of the previous module.
  • Moved captcha styles previously in form.css to its own file.

There is probably more unused CSS, like form error state colors which to my knowledge is not used anywhere, but I'm not sure about that one so I kept it.

One notable change is the removal of type combinator here, which lowers the selector specificity and I noticed one issue where selector .ui.search > .prompt was winning, so I added a workaround for that until the search module can be removed as well.

.ui.form .fields.error .field input:not([type])
.ui.form .fields.error .field input[type="date"]

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2025
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/frontend labels Dec 20, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 21, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants