fix webAuthn insecure error view #36165
Merged
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as you seen, in cureent status `initUserAuthWebAuthn` will prcheck `window.isSecureContext`, if not ok, will hide the `passkey` btton and return directly. I think it's not right, first, not show any error message looks not a good ui, and it's looks will make an empty container was show when registion button was disabled also (maybe f-i-x go-gitea#36115), then initUserAuthWebAuthn has `window.isSecureContext` check also which looks duplcate. so I'd like move hideElem(elSignInPasskeyBtn); to `detectWebAuthnSupport` failed routs to make it simple and show insecure error corectly. Signed-off-by: a1012112796 <[email protected]>
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Dec 15, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Dec 15, 2025
GiteaBot
added
lgtm/done
lunny
added
type/bug
backport/v1.25
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 16, 2025
* origin/main: fix webAuthn insecure error view (go-gitea#36165) Some small refactors (go-gitea#36163) Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143) Enable gocheckcompilerdirectives linter (go-gitea#36156) Fix code highlighting on blame page (go-gitea#36157) Check user visibility when redirecting to a renamed user (go-gitea#36148) Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149)
Collaborator
|
I was unable to create a backport for 1.25. @a1012112796, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 17, 2025
* giteaofficial/main: Automatic generation of release notes (go-gitea#35977) Update chroma to v2.21.0 (go-gitea#36171) [skip ci] Updated translations via Crowdin Move blame to gitrepo (go-gitea#36161) Enable `bodyclose` linter (go-gitea#36168) fix nilnil in onedev downloader (go-gitea#36154) fix webAuthn insecure error view (go-gitea#36165) Some small refactors (go-gitea#36163)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Dec 17, 2025
as you seen, in cureent status `initUserAuthWebAuthn` will prcheck `window.isSecureContext`, if not ok, will hide the `passkey` btton and return directly. I think it's not right, first, not show any error message looks not a good ui, and it's looks will make an empty container was show if the registion button was disabled also (maybe f-i-x go-gitea#36115), then initUserAuthWebAuthn has `window.isSecureContext` check also which looks duplcate ref: https://github.com/go-gitea/gitea/blob/26602fd2070886a1e7e0545f11f5541a38396003/web_src/js/features/user-auth-webauthn.ts#L202-L206 so I'd like move hideElem(elSignInPasskeyBtn); to `detectWebAuthnSupport` failed routs to make it simple and show insecure error corectly.  Signed-off-by: a1012112796 <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
lunny
added a commit
that referenced
this pull request
Dec 17, 2025
backport #36165 Signed-off-by: a1012112796 <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Member
|
We probably need to revert this because now all users that use gitea on non-localhost http will see this useless error message, even if they are not using webauthn. We should only show webauthn errors if they actually originate from a user interaction. |
Member
|
#36219 is the proper fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as you seen, in cureent status
initUserAuthWebAuthnwill prcheckwindow.isSecureContext, if not ok, will hide thepasskeybtton and return directly. I think it's not right, first, not show any error message looks not a good ui, and it's looks will make an empty container was show if the registion button was disabled also (maybe f-i-x #36115), then initUserAuthWebAuthn haswindow.isSecureContextcheck also which looks duplcate ref:gitea/web_src/js/features/user-auth-webauthn.ts
Lines 202 to 206 in 26602fd
so I'd like move hideElem(elSignInPasskeyBtn); to
detectWebAuthnSupportfailed routs to make it simple and show insecure error corectly.