feat: milestone read write search CRUD operations #1560
+2,172
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented ListMilestones, GetMilestone, and MilestoneWrite functions for managing GitHub milestones. - Added corresponding test cases to ensure functionality and error handling. - Created tool definitions and input schemas for each milestone operation. - Included snapshots for tool definitions to facilitate testing and validation. This update enhances the GitHub integration by allowing users to list, retrieve, create, update, and delete milestones in repositories.
- Updated ListMilestones and GetMilestone functions to incorporate a lockdown mode feature, filtering milestones based on creator access. - Introduced a RepoAccessCache to manage access checks efficiently. - Added new test cases to validate the functionality of the lockdown mode, ensuring proper handling of milestones based on creator permissions. - Adjusted tool definitions to accommodate the new parameters for cache and feature flags.
- Updated milestone test cases to ignore the request parameter in handler functions for improved clarity. - Integrated data sanitization for milestone titles and descriptions to ensure safe handling of user input. - Adjusted the milestone summary function to utilize sanitized values, enhancing security and consistency.
- Added documentation for new milestone management functions: get_milestone, list_milestones, and milestone_write. - Included required parameters and options for each function to improve clarity and usability for developers.
- Implemented the search_milestones function to allow searching for repository milestones based on title and description. - Added input schema and validation for required parameters: owner, repo, and query. - Created test cases to validate the functionality, including success scenarios and error handling for invalid inputs. - Updated README to document the new search_milestones tool and its parameters. - Included snapshots for tool definitions to facilitate testing and validation.
- Introduced new test cases for the SearchMilestones function, including wildcard matching and filtering by creator login. - Enhanced the SearchMilestones implementation to support wildcard queries and creator login matching. - Added a test to verify that lockdown mode correctly blocks milestones created by unsafe users. - Improved query handling by trimming whitespace and allowing for empty queries to match all milestones.
blockedby
changed the title
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add milestone CRUD tooling
add search filtering to include creator logins
add creator-lockdown test coverage and wildcard search test
add tests covering creator matching and lockdown behavior for milestones
closes:#258