Don't require body on PR Approval and honor footer: false#15507
Merged
pelikhan merged 3 commits intogithub:mainfrom Feb 13, 2026
Merged
Don't require body on PR Approval and honor footer: false#15507pelikhan merged 3 commits intogithub:mainfrom
footer: false#15507pelikhan merged 3 commits intogithub:mainfrom
Conversation
Contributor
|
ouch... that's annoying. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues related to PR review submissions: removing the incorrect body requirement for APPROVE events and adding support for the footer: false configuration option.
Changes:
- Updated validation logic to only require body for REQUEST_CHANGES events (not APPROVE)
- Added
footerconfiguration option tosubmit-pull-request-reviewthat controls whether AI-generated footer is appended to review body - Modified footer logic to skip footer when disabled or when body is empty
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/agent-output.json | Updated body requirement description and conditional validation to only require body for REQUEST_CHANGES |
| pkg/workflow/js/safe_outputs_tools.json | Updated body requirement description in tool schema |
| actions/setup/js/safe_outputs_tools.json | Updated body requirement description in action tool schema |
| pkg/parser/schemas/main_workflow_schema.json | Added footer boolean field to submit-pull-request-review configuration |
| pkg/workflow/submit_pr_review.go | Added Footer field to config struct and parsing logic |
| pkg/workflow/compiler_safe_outputs_config.go | Added footer config handling using getEffectiveFooter helper |
| actions/setup/js/submit_pr_review.cjs | Updated validation to only require body for REQUEST_CHANGES |
| actions/setup/js/pr_review_buffer.cjs | Added includeFooter flag and logic to conditionally append footer |
| actions/setup/js/safe_output_unified_handler_manager.cjs | Applied footer config from submit_pull_request_review to review buffer |
| actions/setup/js/safe_output_handler_manager.cjs | Applied footer config from submit_pull_request_review to review buffer |
| actions/setup/js/submit_pr_review.test.cjs | Updated tests to validate empty body is allowed for APPROVE and required for REQUEST_CHANGES |
| actions/setup/js/pr_review_buffer.test.cjs | Added tests for footer control and empty body behavior |
| docs/src/content/docs/reference/safe-outputs.md | Updated documentation to reflect correct body requirements and footer option |
| docs/src/content/docs/reference/frontmatter-full.md | Added footer field documentation |
| .github/workflows/smoke-copilot.lock.yml | Updated tool schema description for body requirement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
simple solution is to give me push access 😉 |
Contributor
|
I'm thinking I might give you an workflow to run on your side to enforce all our little rules... |
pelikhan
reviewed
Feb 13, 2026
pelikhan
reviewed
Feb 13, 2026
pelikhan
reviewed
Feb 13, 2026
pelikhan
reviewed
Feb 13, 2026
strawgate
force-pushed
the
dont-require-body-for-approve-v2
branch
from
e1b8169 to
53ec669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15503 and #15505