C/C++ overlay: Add multiloc declaration to Overlay.qll #20995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/locations
branch
from
3cd6fd0 to
596061c
Compare
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/locations
branch
from
596061c to
fcd7ea4
Compare
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/locations
branch
from
fcd7ea4 to
61823ea
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the C++ overlay discard predicates in Overlay.qll to properly handle multi-location entities by adding support for functions, types, namespaces, macros, and preprocessor directives.
- Expands
getSingleLocationFilePathto handle function declarations, type declarations, namespace declarations, macro invocations, and preprocessor directives - Expands
getMultiLocationFilePathto handle function declarations, type declarations, and namespace declarations with multiple locations - Removes TODO comments that are now addressed by the implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jketema
reviewed
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the C++ overlay discard predicates in
Overlay.qllto handle multi-location entities correctly.