feat(seer): Add a banner to bring people into Seer onboarding if they're not done yet #104823
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ryan953
commented
Dec 11, 2025
ryan953
commented
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const {data, isFetched} = useSeerOnboardingCheck(); | ||
|
|
||
| if (!isFetched || data?.isSeerConfigured) { | ||
| return null; |
Contributor
There was a problem hiding this comment.
Bug: Banner shows incorrectly when API request fails
When the useSeerOnboardingCheck API call fails, isFetched becomes true but data is undefined. The condition !isFetched || data?.isSeerConfigured evaluates to false (since undefined?.isSeerConfigured is falsy), causing the banner to display even though the actual configuration status is unknown. The component should also check isError and return null when the API request fails, to avoid showing the onboarding banner when we simply don't know whether Seer is already configured.
dashed
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.