-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(dotnet): add Web.config DSN example for ASP.NET #15876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fuguiKz
wants to merge
1
commit into
getsentry:master
Choose a base branch
from
fuguiKz:docs/dotnet-aspnet-webconfig-dsn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The documentation's code example for ASP.NET will crash the application on startup if the
SentryDsnkey is missing fromWeb.configdue to an unhandledArgumentNullException.Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The code example in the documentation for ASP.NET initialization uses
options.Dsn = ConfigurationManager.AppSettings["SentryDsn"];. If theSentryDsnkey is missing fromWeb.config,ConfigurationManager.AppSettingsreturnsnull. In Sentry SDK 4.0+, passing anullDSN toSentrySdk.Init()throws anArgumentNullException. Because this initialization code is placed inApplication_Start(), the unhandled exception will prevent the application from starting. The documentation fails to warn users that this configuration key is mandatory, making it easy for a developer following the guide to cause a startup crash.💡 Suggested Fix
Update the documentation to include a prominent warning that the
SentryDsnkey inWeb.configis mandatory. Alternatively, modify the code example to include null-checking before assigning the DSN tooptions.Dsnto prevent theSentrySdk.Init()call from throwing an exception if the key is not found.🤖 Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID:
7752030