Fix extra/missing brackets in some barcodes#145
Merged
grahamknockillaree merged 6 commits intogap-packages:masterfrom Jan 26, 2026
Merged
Fix extra/missing brackets in some barcodes#145grahamknockillaree merged 6 commits intogap-packages:masterfrom
grahamknockillaree merged 6 commits intogap-packages:masterfrom
Conversation
Collaborator
|
Thanks for spotting this. I'll add data for n=83 soon. Actually, I think the files for prime n are all the same, so I should not really be including a separate file for each prime. I'll look into this. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 44.74% 44.74%
=======================================
Files 349 349
Lines 64422 64422
=======================================
Hits 28825 28825
Misses 35597 35597 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes or adds brackets to certain barcodes to make the resulting gap files syntactically valid. In particular the derived series for
n=4is has an extra bracket which renders it invalid as gap code. Forn=83all of the barcodes are empty, which seems wrong. I tried fixing it by adding extra brackets to make the files valid gap code, but it might be better to remove the files altogether, unless there is a mathematical reason why there should not be any barcodes forn=83(I don't have enough understanding of the mathematics to know).