DRAFT: Add new rule C#-FriendlyAsyncOverload#586
Draft
parhamsaremi wants to merge 3 commits intofsprojects:masterfrom
Draft
DRAFT: Add new rule C#-FriendlyAsyncOverload#586parhamsaremi wants to merge 3 commits intofsprojects:masterfrom
parhamsaremi wants to merge 3 commits intofsprojects:masterfrom
Conversation
parhamsaremi
changed the title
parhamsaremi
changed the title
Collaborator
|
This PR needs to change because we're going to change the convention: instead of having |
parhamsaremi
force-pushed
the
fix-CSharpFriendlyAsyncOverloads-conflicts
branch
3 times, most recently
from
0a6261e to
70d721f
Compare
Member
|
Not all the libraries are meant for C# use. For example type-providers, they just don't work in C#. |
Collaborator
Good point, that's why this rule won't be enabled by default. |
knocte
added a commit
to knocte/FSharpLint
that referenced
this pull request
Nov 11, 2025
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
knocte
added a commit
to Thorium/FSharpLint
that referenced
this pull request
Nov 11, 2025
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
knocte
added a commit
to Thorium/FSharpLint
that referenced
this pull request
Nov 14, 2025
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
webwarrior-ws
pushed a commit
to webwarrior-ws/FSharpLint
that referenced
this pull request
Nov 17, 2025
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517
NOTE: this PR supersedes an older PR