Conversation
joshuabaird
force-pushed
the
chore/helm-v4-refactor
branch
from
9e97d2b to
d3e721f
Compare
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
joshuabaird
force-pushed
the
chore/helm-v4-refactor
branch
from
c17fc63 to
6817b70
Compare
Signed-off-by: Josh Baird <jbaird@galileo.io>
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
@joshuabaird this looks like a better pattern, I've added a couple of nits that may be useful.
RE the bigger picture, I think the following are worth considering.
- Don't keep the README in this repo
- Keep the README template in the helm-charts repos and generate the README as part of the PR to copy the chart there
- This will make it clearer that the chart in this repo shouldn't be used
- Don't Update Chart.yaml
versionin this repo- Keep
versionstatic (e.g.0.0.1-dev.0) - Update
appVersionas appropriate - Set the version in the PR to copy the chart to the helm-charts repo
- This will make it clearer that the chart in this repo shouldn't be used
- Keep
| @@ -1,3 +1,4 @@ | |||
| {{- if .Values.fluent-bit.enabled }} | |||
| --- | |||
There was a problem hiding this comment.
You don't need and shouldn't have YAML document separators where they're not being used (same goes for all of the rest).
| type: application | ||
| version: 0.2.1 | ||
| appVersion: v3.6.0 | ||
| version: 4.0.0 |
There was a problem hiding this comment.
Why is this already at v4? I'd suggest using either 0.x.0 or 1.0.0-beta.1 while you get this all tested out.
| {{- with .Values.additionalAnnotations }} | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} | ||
| controller-gen.kubebuilder.io/version: v0.18.0 |
There was a problem hiding this comment.
You should remove this as you wouldn't want to churn a CRD for an unrelated annotation change (same goes for all the others). Personally I'd make sure these are removed as part of the gen process.
| appVersion: v3.6.0 | ||
| version: 4.0.0 | ||
| # renovate: datasource=docker depName=ghcr.io/fluent/fluent-operator/fluent-operator | ||
| appVersion: "3.6.0" |
There was a problem hiding this comment.
| appVersion: "3.6.0" | |
| appVersion: 3.6.0 |
2 participants
This PR implements several re-factors for the initial Helm chart v4 release of
fluent-operator:crds/directory of thefluent-operatorchart to follow Helmv3 standards and best practicesfluent-operator-crdschart that enables optional advanced/out-of-band management of the fluentd and fluent-bit CRDsfluent-operatorchartfluent-bit-crdsandfluentd-crdscharts (no longer necessary since we introduced thefluent-operator-crdschart)values.yamlto be compatible withhelm-docsso we can autogenerate docs for the chartfluent-operatorchart README