Make colour picker commit on blur and add draggable popup#323
Closed
tracygardner wants to merge 4 commits intomainfrom
Closed
Make colour picker commit on blur and add draggable popup#323tracygardner wants to merge 4 commits intomainfrom
tracygardner wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ui/colourpicker.cssto render a visible grip and setcursor: moveand appropriate touch behavior.ui/colourpicker.jsvia a newmakePopupDraggable()method that constrains the popup position to the canvas parent and setsthis.userMovedPickerto preserve manual placement on reopen.close(options)signature with flagscommitColorandtriggerOnClose, and updated backdrop/outside-click handlers andconfirmColor()to use these flags so outside-close commits the selected color.open()to skip automatic repositioning if the user has manually moved the picker, preserving the user-chosen location.Testing
npm run build, which completed successfully (build warnings about large chunks were reported but the build succeeded).npm run devand performed manual verification of the picker UI and drag behavior..color-picker-drag-handle, and captured a screenshot artifact showing the draggable popup (script executed and produced the artifact).Codex Task