Auto-enter/exit paint mode from color picker (mouse hover + touch support)#322
Closed
tracygardner wants to merge 2 commits intomainfrom
Closed
Auto-enter/exit paint mode from color picker (mouse hover + touch support)#322tracygardner wants to merge 2 commits intomainfrom
tracygardner wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ui/gizmos.jsto manage automatic transitions and explicit activation for coarse pointers.activatePaintMode()onpointerleaveof the picker content anddeactivatePaintMode()onpointerenter, and bound handlers dynamically viabindPickerHoverHandlers()/detachPickerHoverHandlers()..color-picker-use) into the picker API by adding anonPaintButtonClickcallback inui/colourpicker.js, changed the button to trigger paint mode (instead of confirming/closing), and addedupdatePaintModeButtonVisual()to show/remove the colored border while active..color-picker-use.paint-mode-activeinui/colourpicker.cssto render a border/glow that matches the currently selected color via--paint-mode-color.Testing
npm run buildand the build completed successfully.npm run devand verified the app served locally.browser:/tmp/codex_browser_invocations/787b221ccc7c4722/artifacts/artifacts/color-picker-paint-mode.pngwhich demonstrates the active paint-button visual.Codex Task