-
Notifications
You must be signed in to change notification settings - Fork 2
Improve notification silence docs #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adityathebe
wants to merge
8
commits into
main
Choose a base branch
from
docs/silences-crd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−41
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4d3756f
docs: notification silences example and improvements
adityathebe 0464273
docs: CRD reference
adityathebe 5db953f
docs(silences): link to full resource selector reference instead of i…
adityathebe b7665a3
docs(silences): update resource selection docs and remove component e…
adityathebe 7e90f44
docs(notifications): add missing CEL template variables
adityathebe 4c02222
submodules sync
adityathebe b69e186
chore: remove image
adityathebe d5edf89
chore: fix formatting
adityathebe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule mission-control-chart
updated
4 files
| +2 −2 | agent-chart/Chart.yaml | |
| +1 −1 | agent-chart/values.yaml | |
| +3 −3 | chart/Chart.yaml | |
| +1 −1 | chart/values.yaml |
Binary file removed
BIN
-58 KB
mission-control/docs/guide/notifications/concepts/silence-notification-form.png
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <Fields withTemplates="true" rows={[ | ||
| { | ||
| field: "description", | ||
| description: "A description explaining the purpose of the silence", | ||
| scheme: "string" | ||
| }, | ||
| { | ||
| field: "from", | ||
| description: "Start time of the silence period in RFC3339 format, datetime or datemath expression (e.g., \"now\", \"now+2h\", \"2025-01-01\")", | ||
| scheme: "string" | ||
| }, | ||
| { | ||
| field: "until", | ||
| description: "End time of the silence period in RFC3339 format, datetime or datemath expression (e.g., \"now\", \"now+2d\", \"2025-02-01\")", | ||
| scheme: "string" | ||
| }, | ||
| { | ||
| field: "recursive", | ||
| description: "When true, the silence applies to all child resources of the matched resources. For example, silencing a namespace would silence all deployments, statefulsets, pods, etc. within it.", | ||
| scheme: "boolean" | ||
| }, | ||
| { | ||
| field: "filter", | ||
| description: "A CEL expression that determines whether to apply the silence. The silence is only applied if the filter evaluates to true.", | ||
| scheme: "CEL", | ||
| templateEnv: [ | ||
| {"name": "CheckEvents", "url": "/docs/reference/notifications/template_vars/checks"}, | ||
| {"name": "ConfigEvents", "url": "/docs/reference/notifications/template_vars/config"}, | ||
| ], | ||
adityathebe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| { | ||
| field: "selectors", | ||
| description: "List of resource selectors to target specific resources", | ||
| scheme: "[[]ResourceSelector](/docs/reference/resource-selector)" | ||
| } | ||
| ]}/> | ||
|
|
||
| :::info | ||
| At least one of `filter` or `selectors` must be specified to target resources for the silence. When both are specified, `filter` takes precedence. | ||
| ::: | ||
Submodule canary-checker
updated
31 files
| +41 −11 | .github/workflows/build.yml | |
| +2 −0 | .gitignore | |
| +11 −1 | api/context/context.go | |
| +64 −0 | api/context/context_test.go | |
| +5 −2 | api/v1/checks.go | |
| +1 −1 | api/v1/common.go | |
| +15 −3 | build/full/Dockerfile | |
| +16 −3 | build/minimal/Dockerfile | |
| +15 −7 | build/slim/Dockerfile | |
| +8 −2 | checks/exec.go | |
| +35 −10 | checks/github.go | |
| +10 −1 | checks/runchecks.go | |
| +3 −4 | cmd/run.go | |
| +3 −0 | config/deploy/Canary.yml | |
| +3 −0 | config/deploy/manifests.yaml | |
| +2 −1 | config/schemas/canary.schema.json | |
| +2 −1 | config/schemas/component.schema.json | |
| +2 −1 | config/schemas/health_github.schema.json | |
| +2 −1 | config/schemas/topology.schema.json | |
| +0 −20 | fixtures/git/_setup.sh | |
| +0 −16 | fixtures/git/git_check_pass.yaml | |
| +0 −17 | fixtures/git/git_test_expression_pass.yaml | |
| +0 −2 | fixtures/git/kustomization.yaml | |
| +169 −0 | fixtures/selftest/container-selftest-full.yaml | |
| +142 −0 | fixtures/selftest/container-selftest-minimal.yaml | |
| +55 −0 | fixtures/selftest/container-selftest-slim.yaml | |
| +7 −2 | go.mod | |
| +14 −2 | go.sum | |
| +7 −3 | pkg/api.go | |
| +2 −2 | pkg/results.go | |
| +3 −3 | pkg/system_api.go |
Submodule config-db
updated
9 files
| +20 −7 | Makefile | |
| +71 −0 | fixtures/data/k8s_rbac_access_test.json | |
| +12 −0 | fixtures/file-k8s-rbac-access.yaml | |
| +1 −1 | go.mod | |
| +2 −2 | go.sum | |
| +23 −0 | scrapers/kubernetes/kubernetes.go | |
| +501 −0 | scrapers/kubernetes/rbac.go | |
| +504 −0 | scrapers/kubernetes/rbac_test.go | |
| +140 −0 | scrapers/run_test.go |
Submodule duty
updated
6 files
| +7 −5 | context/kuberetes_client.go | |
| +1 −0 | models/checks.go | |
| +1 −0 | models/config_access.go | |
| +16 −0 | query/getters.go | |
| +15 −3 | schema/config_access.hcl | |
| +1 −0 | views/013_check_summary.sql |
Submodule mission-control
updated
30 files
Submodule mission-control-chart
updated
4 files
| +2 −2 | agent-chart/Chart.yaml | |
| +1 −1 | agent-chart/values.yaml | |
| +3 −3 | chart/Chart.yaml | |
| +1 −1 | chart/values.yaml |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.