feat(go/plugins/mcp): migrate MCP underlying SDK to modelcontextprotocol #4388
feat(go/plugins/mcp): migrate MCP underlying SDK to modelcontextprotocol #4388hugoaguirre wants to merge 13 commits intomainfrom
modelcontextprotocol #4388Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant and well-executed migration from mark3labs/mcp-go to the official modelcontextprotocol/go-sdk. The changes simplify the codebase, especially in areas like pagination and transport creation, and align it with the new SDK's idioms. The addition of comprehensive integration tests (http_test.go) is a great improvement and increases confidence in the new implementation. I've made a few suggestions to improve context handling and error management. Overall, this is a high-quality contribution.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is a significant and well-executed migration of the MCP plugin to a new underlying SDK. The changes are extensive, resulting in cleaner code, better use of context.Context, and the addition of valuable new features like HTTP/SSE server support and telemetry tracing. The inclusion of comprehensive new tests is also a great improvement. I've identified a couple of minor areas for improvement: a potential feature regression regarding server management in MCPHost and an ignored error in a deprecated function that could be logged for better diagnostics. Overall, this is a high-quality contribution.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
2 participants
mark3labs/mcp-gotomodelcontextprotocol/go-sdkNewClient,*WithContext())Checklist (if applicable):