-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: sessions flakes #15629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: sessions flakes #15629
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix flaky tests by adding sync blocks to wait for background queue operations. The approach is sound and should improve test stability. The added block in setUp() correctly isolates tests by draining the queue from previous runs. I've added one comment on the second added block in runSessionsSDK() to suggest improving a comment for clarity and to point out code duplication that could be refactored.
The flakes are most likely due to:
firebase-ios-sdk/FirebaseSessions/Sources/FirebaseSessions.swift
Line 182 in 54a9296
May need to mirror the approach from #15623
#no-changelog