-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat/pipeline/private-preview to main #15625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Morgan Chen <[email protected]>
…ode/` directory (#14833) Co-authored-by: Morgan Chen <[email protected]>
…ervice/` directory (#14839) Co-authored-by: Morgan Chen <[email protected]>
Co-authored-by: Morgan Chen <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
wu-hui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some ultranits.
nk-1983
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Danger has errored[!] Invalid Generated by 🚫 Danger |
|
Looks like the "Bridge" types introduced in this PR broke CI - https://github.com/firebase/firebase-ios-sdk/actions/runs/20474176486/job/58835500791?pr=15638 |
More examples in the nightly testing report: #15607 (comment) |
All public APIs are located under
Firestore/Swift/Source/SwiftAPI/Pipeline. Thanks to the technical writer for reviewing them.