Conversation
312953e to
a3f5bc6
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's build configuration by upgrading the required C++ standard from C++14 to C++17. This change allows the codebase to leverage newer language features and improvements available in C++17, potentially enhancing code quality, performance, and developer productivity. The update is applied consistently across the main project and all integration test modules. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the C++ standard from 14 to 17 across various CMakeLists.txt files. The changes are straightforward, but several files have outdated comments that still refer to C++14. I've added suggestions to update these comments for consistency and maintainability.
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
| # Firebase C++ SDK requires C++14. | ||
| set (CMAKE_CXX_STANDARD 14) | ||
| set (CMAKE_CXX_STANDARD 17) |
Description
Update to c++ 17
Testing
Currently running all test apps on desktop, iOS and android
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.