refactor: remove any and as throughout codebase#1323
refactor: remove any and as throughout codebase#1323jescalada wants to merge 69 commits intofinos:mainfrom
any and as throughout codebase#1323Conversation
…ttestation definition
…elds, remove any in src/proxy/routes/index
Sets stub types to (`ReturnType<typeof vi.fn>`) to remove the any type
…for req and stubs
…/jescalada/git-proxy into 1174-remove-any-and-as-ts-wrapup
…y, jwtAuthHandler)
… for edge case tests
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
|
@kriswest Ready for a final look! |
|
@jescalada trying to fit in a final pass, but you've developed a whole load of conflicts unfortunately. |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Mostly LGTM, one small issue. The very large diff includes changes from other PRs - that can be avoided by rebasing main rather than merging in future.
I think it best if this goes in ASAP as its getting way too long to review effectively.
One small error to fix + a minor refinement suggested.
Co-authored-by: Kris West <[email protected]> Signed-off-by: Juan Escalada <[email protected]>
|
@kriswest Should be ready now! Coverage is 89.69%, which is much better than I imagined despite the extra code. Might be worth taking another pass at improving coverage down the line, but we're at a much better spot compared to March last year (62%). |
|
@jescalada gah merging the license header PR touched all 109 files again 😭 These beasts are best off rebased whereever possible so the diff only shows this PRs changes, rather than everything merged into them. Hopefully that results in the same number of conflicts to resolve, although that depends on how much rework happened in the PR. Edit: ignore me, github review interface was miscounting changes - not all 109 were touched (more like 80 or 90) |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
One or two minor issues to correct still (including a couple of places we've picked up double license headers), a couple of minor improvement suggestions and one thing I think you should revert (in an area I feel like I should have hung an "abandon hope all ye who enter here" sign on!)
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
One or two minor issues to correct still (including a couple of places we've picked up double license headers), a couple of minor improvement suggestions and one thing I think you should revert (in an area I feel like I should have hung an "abandon hope all ye who enter here" sign on!)
Co-authored-by: Kris West <[email protected]> Signed-off-by: Juan Escalada <[email protected]>
Co-authored-by: Kris West <[email protected]> Signed-off-by: Juan Escalada <[email protected]>
…/jescalada/git-proxy into 1174-remove-any-and-as-ts-wrapup
|
@kriswest Ready for another look! |
2 participants
Fixes #1174.