fix: defer onboarding-time restarts until setup is complete#4580
Open
ComputelessComputer wants to merge 2 commits intomainfrom
Open
fix: defer onboarding-time restarts until setup is complete#4580ComputelessComputer wants to merge 2 commits intomainfrom
ComputelessComputer wants to merge 2 commits intomainfrom
Conversation
Collaborator
ComputelessComputer
commented
Mar 14, 2026
ComputelessComputer
commented
- queue automatic app relaunches while onboarding is still required
- restart after onboarding finishes so system-audio and storage changes still apply
- add focused tests for the relaunch coordinator
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
/staging |
|
Collaborator
Author
|
/staging |
|
Collaborator
Author
|
confirming that it works just fine — could change the native alert message to smth like:
BUT we should check first if this is unnecessary in the first place as @yujonglee pointed out. |
- queue automatic app relaunches while onboarding is still required - restart after onboarding finishes so system-audio and storage changes still apply - add focused tests for the relaunch coordinator
- delay the system audio restart modal until onboarding finishes - mark system audio as authorized locally after a successful request - keep the deferred restart flow intact by showing the modal right before relaunch
ComputelessComputer
force-pushed
the
c-branch-1
branch
from
a54d18b to
296c19d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.