Skip to content

Apply cargo clippy fixes and format with cargo fmt#4575

Open
devin-ai-integration[bot] wants to merge 5 commits intomainfrom
devin/1773446629-clippy-fixes
Open

Apply cargo clippy fixes and format with cargo fmt#4575
devin-ai-integration[bot] wants to merge 5 commits intomainfrom
devin/1773446629-clippy-fixes

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 14, 2026

Summary

Ran cargo clippy --fix followed by cargo fmt and dprint fmt across the workspace. The effective changes span 3 files:

  1. Clippy lint fixes (semantic changes):

    • Collapsed nested if/if let blocks into if let chain using && syntax (cactus/batch.rs)
    • Removed unnecessary explicit lifetime annotations on partition_tokens_by_word_finality (soniox/live.rs)
  2. Workspace config (Cargo.toml): Excluded plugins/apple-contact and plugins/pdf from workspace members (these directories have no Cargo.toml, only node_modules/, which blocks cargo from resolving the workspace).

Review & Testing Checklist for Human

  • Check if let chain syntax compatibility — The collapsed if let ... && ... syntax in cactus/batch.rs requires Rust 1.87.0+. Confirm the project's toolchain/MSRV supports this.
  • Verify new workspace exclusionsplugins/apple-contact and plugins/pdf are excluded because they lack a Cargo.toml. Confirm these shouldn't have a Cargo.toml added instead.

Notes

  • The fmt CI check passes. The only failing check (desktop_ci linux-x86_64) is a pre-existing cactus-sys ARM architecture build error on x86, unrelated to this PR.
  • Devin Session
  • Requested by: bot_apk

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Mar 14, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 3a2dc04
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/69b4addc4cabb80008b63a43

@netlify
Copy link

netlify bot commented Mar 14, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 3a2dc04
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69b4addc76b54f00085b4cb0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants