[Compiler] Fix false positive for setState after await in useEffect

[basitqayoom]

Summary

Fixes #34905

The set-state-in-effect validation (ValidateNoSetStateInEffects) was incorrectly flagging setState calls that appear after an await expression inside async functions called from useEffect.

After an await, execution continues asynchronously in a microtask — meaning the setState call is no longer synchronous within the effect body and should not trigger this lint.

Root cause

In getSetStateCall(), the function walks through the HIR of the effect callback and returns the first setState call it finds, without distinguishing whether that call appears after an Await instruction.

Fix

Added Await instruction tracking within each block in getSetStateCall():

• When an Await instruction is encountered, a seenAwait flag is set for the current block
• Any subsequent setState call in the same block after an Await is skipped (not reported as synchronous)

This is a conservative fix scoped to intra-block tracking. Cross-block await dominator analysis can be added as a follow-up if needed.

How did you test this change?

Added 3 new test fixtures:

Fixture	Expected	Description
allow-setState-in-useEffect-after-await	✅ No error	setState after await via useCallback + useEffect (exact issue repro)
allow-setState-in-useEffect-async-callback	✅ No error	setState after await in nested async function inside useEffect
invalid-setState-in-useEffect-before-await	❌ Error reported	setState before await is still correctly flagged

All existing tests continue to pass:

$ yarn snap -- -p "invalid-setState-in-useEffect*"
5 Tests, 5 Passed, 0 Failed

$ yarn workspace eslint-plugin-react-compiler test
Test Suites: 8 passed, 8 total
Tests:       31 passed, 31 total

[meta-cla]

Hi @basitqayoom!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!