I added a test that asserts malformed profiling operations do not throw and that errors/warnings are logged

[apoorvgarewal07]

1. Builds minimal fake profiling data with a valid initial snapshot.
2. Injects malformed operations (duplicate add, remove of missing node, remove root, and an unsupported op).
3. Asserts that getCommitTree does not throw and that console.error / console.warn were called.

[meta-cla]

Hi @apoorvgarewal07!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[aydenhailey78-hub]

Appreciate the info

…

On Mon, Feb 2, 2026 at 7:59 PM apoorvgarewal07 ***@***.***> wrote: 1. Builds minimal fake profiling data with a valid initial snapshot. 2. Injects malformed operations (duplicate add, remove of missing node, remove root, and an unsupported op). 3. Asserts that getCommitTree does not throw and that console.error / console.warn were called. ------------------------------ You can view, comment on, or merge this pull request online at: #35674 Commit Summary - 61141cd <61141cd> I added a test that asserts malformed profiling operations do not throw and that errors/warnings are logged - 98c13a1 <98c13a1> Merge branch 'main' of https://github.com/facebook/react File Changes (2 files <https://github.com/facebook/react/pull/35674/files>) - *M* packages/react-devtools-shared/src/__tests__/profilingCommitTreeBuilder-test.js <https://github.com/facebook/react/pull/35674/files#diff-4dc8f594a6d4f4f7c12e2f52dcaf4222d5914ccce28e22cf22ee80b85c6a11af> (81) - *M* packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js <https://github.com/facebook/react/pull/35674/files#diff-b0fa4c5c45a6769a2f527cebb7dce18466e4aeb9eb59a27a74bf29f7c9d557e4> (21) Patch Links: - https://github.com/facebook/react/pull/35674.patch - https://github.com/facebook/react/pull/35674.diff — Reply to this email directly, view it on GitHub <#35674>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/B4CX3QC3TWQW2VU3LDG7JLD4J6UDHAVCNFSM6AAAAACTXGIHBWVHI2DSMVQWIX3LMV43ASLTON2WKOZTHA4DONRQGY4DONQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[djhdusjbd-eng]

Looks good

…

On Mon, Feb 2, 2026 at 7:59 PM apoorvgarewal07 ***@***.***> wrote: 1. Builds minimal fake profiling data with a valid initial snapshot. 2. Injects malformed operations (duplicate add, remove of missing node, remove root, and an unsupported op). 3. Asserts that getCommitTree does not throw and that console.error / console.warn were called. ------------------------------ You can view, comment on, or merge this pull request online at: #35674 Commit Summary - 61141cd <61141cd> I added a test that asserts malformed profiling operations do not throw and that errors/warnings are logged - 98c13a1 <98c13a1> Merge branch 'main' of https://github.com/facebook/react File Changes (2 files <https://github.com/facebook/react/pull/35674/files>) - *M* packages/react-devtools-shared/src/__tests__/profilingCommitTreeBuilder-test.js <https://github.com/facebook/react/pull/35674/files#diff-4dc8f594a6d4f4f7c12e2f52dcaf4222d5914ccce28e22cf22ee80b85c6a11af> (81) - *M* packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js <https://github.com/facebook/react/pull/35674/files#diff-b0fa4c5c45a6769a2f527cebb7dce18466e4aeb9eb59a27a74bf29f7c9d557e4> (21) Patch Links: - https://github.com/facebook/react/pull/35674.patch - https://github.com/facebook/react/pull/35674.diff — Reply to this email directly, view it on GitHub <#35674>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/B4CX4CD6QG65WX7PUMXP2YD4J6UDHAVCNFSM6AAAAACTXGIHBWVHI2DSMVQWIX3LMV43ASLTON2WKOZTHA4DONRQGY4DONQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>