chore: upgrade to jest 25 by SimenB · Pull Request #17896 · facebook/react

SimenB · 2020-01-23T14:02:28Z

Summary

The changes to the test code relate to changes in JSDOM that come with Jest 25:

Several JSDOM workarounds are no longer needed.
Several tests made assertions to match incorrect JSDOM behavior (e.g. setAttribute calls) that JSDOM has now patched to match browsers.
- https://codesandbox.io/s/resets-value-of-datetime-input-to-fix-bugs-in-ios-safari-1ppwh
JSDOM no longer triggers default actions when dispatching click events.
- https://codesandbox.io/s/beautiful-cdn-ugn8f
JSDOM fixed (fix: Focusing focused dispatching FocusEvent jsdom/jsdom#2700) a bug so that calling focus() on an already focused element does not dispatch a FocusEvent.
JSDOM now supports passive events.
JSDOM has improved support for custom CSS properties.
- But requires fix: webkit properties not being recognized jsdom/cssstyle#112 to land to support webkit prefixed properties.

Closes #17012

Test Plan

yarn test

codesandbox-ci · 2020-01-23T14:04:08Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1c7d66:

Sandbox	Source
jovial-chaum-9wfnj	Configuration
resets value of date/time input to fix bugs in iOS Safari	PR
quiet-dawn-mn9or	PR

sizebot · 2020-01-23T14:07:52Z

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against d1c7d66

sizebot · 2020-01-23T14:09:16Z

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against d1c7d66

SimenB · 2020-01-23T14:15:43Z

I can update babel separately and fix the transform errors.

EDIT: #17897

eps1lon · 2020-01-23T14:29:27Z

Bad news: custom css properties are still not working using jsdom
good news: This will be resolved in cssstyle (jsdom/cssstyle#89) and will likely not need jsdom 16.

SimenB · 2020-01-23T14:37:12Z

will likely not need jsdom 16.

can use a custom env to get jsdom 16 in, if needed: https://www.npmjs.com/package/jest-environment-jsdom-sixteen

eps1lon · 2020-01-24T13:27:00Z

@SimenB SimenB#837 should include all fixes to make JSDOM happy.

@trueadm might want to take a look at the change Drag-Test.internal

trueadm · 2020-01-24T13:30:54Z

Can you link me to the change you’re referring to? Thanks :)

SimenB · 2020-01-24T14:33:23Z

@eps1lon @trueadm I merged in the changes into this PR

packages/react-interactions/events/src/dom/__tests__/Drag-test.internal.js

trueadm

The drag tests shouldn't need changing. It suggests something is up with JSDOM if they do? I'll take a deeper look on Monday unless @necolas has any ideas (we haven't touched this code in a while).

eps1lon · 2020-01-24T18:00:15Z

It suggests something is up with JSDOM if they do?

As I said it's probably something with JSDOM supporting passive event listeners (see SimenB#837 (comment))

trueadm · 2020-01-24T18:02:29Z

Let me look at changing the Drag tests quickly. Maybe that will help. Update: done in #17896

packages/react-dom/src/events/__tests__/ChangeEventPlugin-test.internal.js

packages/react-dom/src/__tests__/ReactDOMInput-test.js

packages/react-dom/src/events/__tests__/SelectEventPlugin-test.js

trueadm · 2020-01-24T18:24:57Z

It would also be good to know why all the click events were changed from MouseEvents to .click(). Is this another breaking change in JSDOM?

eps1lon · 2020-01-24T18:29:26Z

It would also be good to know why all the click events were changed from MouseEvents to .click(). Is this another breaking change in JSDOM?

I took all the time to no only fix it, but prepare a PR, annoate changes and prepare codesandboxes with actual browser behavior. Could you respond to these statements instead? It's not clear if I didn't communicate them well enough or if you just ignored them.

necolas · 2020-01-24T18:40:09Z

Yeah it's helpful if the context goes into the PR summary. We don't usually expect context to be found in a PR against another repo.

trueadm · 2020-01-24T18:41:16Z

@eps1lon Sorry if I wasn't clear. I wasn't criticising your work – this is all awesome! I believe I'm also missing the context to the original code somewhere – I can't see any codesandboxes or comments in this PR? I don't see anything in this PR's summary about any of this.

I also wrote the above comment, before your above comments to @necolas, which help expand and clarify on points.

necolas · 2020-01-24T18:45:41Z

I updated the PR summary with the relevant context behind the changes

necolas · 2020-01-24T18:57:36Z

packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js

          <div
            style={{
              lineClamp: 10,
-              WebkitLineClamp: 10,


Not sure why we have this. lineClamp isn't a valid CSS property...

necolas · 2020-01-24T18:58:22Z

If you could please rebase this on top of latest master, it looks good to me.

SimenB · 2020-01-24T19:00:24Z

I won't be at a computer for a few hours, so if you could rebase that'd be sweet. If not I'll get to it later 🙂

SimenB · 2020-01-25T09:07:59Z

Never got to it yesterday, but rebased now! 👍

gaearon · 2020-01-25T13:26:05Z

Wow this is great, thank you! Leaving for @necolas to merge.

This reverts commit cf00812. The changes to the test code relate to changes in JSDOM that come with Jest 25: * Several JSDOM workarounds are no longer needed. * Several tests made assertions to match incorrect JSDOM behavior (e.g. setAttribute calls) that JSDOM has now patched to match browsers. * https://codesandbox.io/s/resets-value-of-datetime-input-to-fix-bugs-in-ios-safari-1ppwh * JSDOM no longer triggers default actions when dispatching click events. * https://codesandbox.io/s/beautiful-cdn-ugn8f * JSDOM fixed (jsdom/jsdom#2700) a bug so that calling focus() on an already focused element does not dispatch a FocusEvent. * JSDOM now supports passive events. * JSDOM has improved support for custom CSS properties. * But requires jsdom/cssstyle#112 to land to support webkit prefixed properties.

acdlite · 2020-03-24T17:19:33Z

Heads up, I'm reverting this in #18376 because of a Jest bug that is fixed in master but unreleased: jestjs/jest#9575

This reverts commit cf00812. The changes to the test code relate to changes in JSDOM that come with Jest 25: * Several JSDOM workarounds are no longer needed. * Several tests made assertions to match incorrect JSDOM behavior (e.g. setAttribute calls) that JSDOM has now patched to match browsers. * https://codesandbox.io/s/resets-value-of-datetime-input-to-fix-bugs-in-ios-safari-1ppwh * JSDOM no longer triggers default actions when dispatching click events. * https://codesandbox.io/s/beautiful-cdn-ugn8f * JSDOM fixed (jsdom/jsdom#2700) a bug so that calling focus() on an already focused element does not dispatch a FocusEvent. * JSDOM now supports passive events. * JSDOM has improved support for custom CSS properties. * But requires jsdom/cssstyle#112 to land to support webkit prefixed properties.

This reverts commit fc7835c.

* Revert "Revert "Upgrade to jest 25 (#17896)" (#18376)" This reverts commit fc7835c. * Other fixes * Fix a broken test

SimenB mentioned this pull request Jan 23, 2020

chore: upgrade jsdom #17012

Closed

facebook-github-bot added the CLA Signed label Jan 23, 2020

SimenB mentioned this pull request Jan 23, 2020

chore: update to latest release of babel #17897

Merged

eps1lon mentioned this pull request Jan 23, 2020

feat: Implement read/write of custom properties jsdom/cssstyle#111

Merged

trueadm mentioned this pull request Jan 24, 2020

[WIP] Upgrade to Jest 25 #17904

Closed

trueadm reviewed Jan 24, 2020

View reviewed changes

packages/react-interactions/events/src/dom/__tests__/Drag-test.internal.js Outdated Show resolved Hide resolved

trueadm reviewed Jan 24, 2020

View reviewed changes

packages/react-interactions/events/src/dom/__tests__/Drag-test.internal.js Outdated Show resolved Hide resolved

trueadm reviewed Jan 24, 2020

View reviewed changes

packages/react-interactions/events/src/dom/__tests__/Drag-test.internal.js Outdated Show resolved Hide resolved

trueadm suggested changes Jan 24, 2020

View reviewed changes

necolas reviewed Jan 24, 2020

View reviewed changes

packages/react-dom/src/events/__tests__/ChangeEventPlugin-test.internal.js Show resolved Hide resolved

packages/react-dom/src/__tests__/ReactDOMInput-test.js Show resolved Hide resolved

packages/react-dom/src/events/__tests__/SelectEventPlugin-test.js Show resolved Hide resolved

necolas mentioned this pull request Jan 24, 2020

Use CommonJS outside of src #17903

Closed

trueadm mentioned this pull request Jan 24, 2020

[react-interactions] use dom-event-testing-library for Drag tests #17906

Closed

necolas reviewed Jan 24, 2020

View reviewed changes

SimenB and others added 9 commits January 25, 2020 10:06

chore: upgrade to jest 25

9a9e26b

fix: JSDOM no longer calls setAttribute

68d8cc6

fix: click dispatch does not trigger defaults

7ae74ae

fix: JSDOM workaround for select with no value

eec0986

fix: JSDOM supports passive events

5234bb3

fix: jsdom no longer fires duplicate Focus

153bd56

fix: tests regarding css custom properties

5cde17c

lint

1280a71

chore: update dom fixtures lockfile

d1c7d66

SimenB force-pushed the jest-25 branch from 36893e1 to d1c7d66 Compare January 25, 2020 09:08

gaearon approved these changes Jan 25, 2020

View reviewed changes

necolas merged commit cf00812 into facebook:master Jan 25, 2020

SimenB deleted the jest-25 branch January 25, 2020 16:43

gaearon mentioned this pull request Mar 24, 2020

Downgrade Jest to 24 #18376

Merged

gaearon added a commit to gaearon/react that referenced this pull request Apr 3, 2020

Revert "Revert "Upgrade to jest 25 (facebook#17896)" (facebook#18376)"

ea41676

This reverts commit fc7835c.

gaearon mentioned this pull request Apr 3, 2020

Update to Jest 25 #18480

Merged

gaearon added a commit that referenced this pull request Apr 3, 2020

Update to Jest 25 (#18480)

a8f2165

* Revert "Revert "Upgrade to jest 25 (#17896)" (#18376)" This reverts commit fc7835c. * Other fixes * Fix a broken test

Conversation

SimenB commented Jan 23, 2020 • edited by necolas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

codesandbox-ci bot commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sizebot commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size changes (experimental)

Uh oh!

sizebot commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size changes (stable)

Uh oh!

SimenB commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon commented Jan 23, 2020

Uh oh!

SimenB commented Jan 23, 2020

Uh oh!

eps1lon commented Jan 24, 2020

Uh oh!

trueadm commented Jan 24, 2020

Uh oh!

SimenB commented Jan 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trueadm left a comment

Choose a reason for hiding this comment

Uh oh!

eps1lon commented Jan 24, 2020

Uh oh!

trueadm commented Jan 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trueadm commented Jan 24, 2020

Uh oh!

eps1lon commented Jan 24, 2020

Uh oh!

necolas commented Jan 24, 2020

Uh oh!

trueadm commented Jan 24, 2020

Uh oh!

necolas commented Jan 24, 2020

Uh oh!

necolas Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

necolas commented Jan 24, 2020

Uh oh!

SimenB commented Jan 24, 2020

Uh oh!

SimenB commented Jan 25, 2020

Uh oh!

gaearon commented Jan 25, 2020

Uh oh!

acdlite commented Mar 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

SimenB commented Jan 23, 2020 •

edited by necolas

Loading

codesandbox-ci bot commented Jan 23, 2020 •

edited

Loading

sizebot commented Jan 23, 2020 •

edited

Loading

sizebot commented Jan 23, 2020 •

edited

Loading

SimenB commented Jan 23, 2020 •

edited

Loading

trueadm commented Jan 24, 2020 •

edited

Loading