Skip to content

Conversation

@anantone
Copy link

The two tests "test_error_for_smallest_if_min_more_than_max" and "test_error_for_largest_if_min_more_than_max" were both calling smallest. The latter now calls largest as advertised.

The two tests "test_error_for_smallest_if_min_more_than_max" and "test_error_for_largest_if_min_more_than_max" were both calling `smallest'. The later now calls `largest` as advertised.
@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions bot closed this Sep 15, 2025
@anantone
Copy link
Author

anantone commented Sep 15, 2025

This is affecting one of the tests, which at the present is only a duplicate of the previous one, due to a typo. In most cases, this should not change the results of the tests for individual students. Still, I'm unsure if [no important files changed]

@anantone anantone deleted the palindrome-typo branch September 15, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants