ONNX to Tensorflow.js conversion of GPT-2#927
Merged
Conversation
martinjaggi
reviewed
Jul 4, 2025
Member
martinjaggi
left a comment
There was a problem hiding this comment.
amazing work, thanks a lot!
later i'd be very curious to check if also the conversion in the reverse direction (to onnx) works fine.
ae33116 to
99e2db4
Compare
772832d to
464ff8b
Compare
tharvik
approved these changes
Jan 9, 2026
Collaborator
tharvik
left a comment
There was a problem hiding this comment.
haa, that's great work, well done in hacking around the onnx protobuf!
nothing blocking (except the tsc --build thing), only a few nitpicks and questions here and there
464ff8b to
7052329
Compare
7052329 to
9fbe6b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap:
The table below shows the accuracy along with the time of the evaluation on the whole HellaSwag for each model tested: