Revert "Allow numbers in literal/1 (#4562)" and add identifier/1 and constant/1 instead#4563
Merged
greg-rychlewski merged 4 commits intoelixir-ecto:masterfrom Jan 9, 2025
Merged
Conversation
Member
|
For deprecation we can remove the literal and make it sure it emits a warning, a compile-time warning being best. Internally, we can rewrite |
josevalim
approved these changes
Jan 9, 2025
Member
Author
|
@josevalim sorry before I merge, does the way I did the deprecation look alright to you? |
Member
|
ship it!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on our discussions, it seems there is agreement that the old
literal/1should be deprecated and we should make two new "functions": one for identifiers and one for constant values.There was agreement by some people for
identifier/1andconstant/1. If you are not in favour of those names let me know! It won't affect the PR much.Also, I'm not sure what is the normal deprecation procedure. I think we need to keep accepting
literal/1to not break apps? If so should we remove it from the documentation or put some notes in the documentation about it being deprecated and replaced by these 2?Companion Ecto SQL PR: elixir-ecto/ecto_sql#652