Remove general preference memento handling in debug tests #2385
+20
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The superclass of all debug tests manages a preference memento to restore initial preferences after a test case execution. This is, however, only used by two actual tests, such that providing it for every debug test is not necessary and leads to unnecessary complexity in the hierarchy of test classes. This change moves the preference memento to exactly those two test classes in which it is required, as a prerequisite for simplifying the inheritance hierarchy and moving to JUnit 5.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The superclass of all debug tests manages a preference memento to restore initial preferences after a test case execution. This is, however, only used by two actual tests, such that providing it for every debug test is not necessary and leads to unnecessary complexity in the hierarchy of test classes.
This change moves the preference memento to exactly those two test classes in which it is required, as a prerequisite for simplifying the inheritance hierarchy and moving to JUnit 5.