-
Notifications
You must be signed in to change notification settings - Fork 3
Long Operations Improvements #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b96af0e
cb4714c
a8327e3
edf15dd
79349df
0e9c959
7ce5683
2f778a9
6f68f4c
8976cc3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -20,7 +20,6 @@ | |||||
| import com.fasterxml.jackson.core.JsonProcessingException; | ||||||
| import com.fasterxml.jackson.core.type.TypeReference; | ||||||
| import com.fasterxml.jackson.databind.JavaType; | ||||||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||||||
| import com.fasterxml.jackson.databind.SerializationFeature; | ||||||
| import com.fasterxml.jackson.databind.json.JsonMapper; | ||||||
| import com.fasterxml.jackson.dataformat.xml.XmlMapper; | ||||||
|
|
@@ -53,19 +52,19 @@ public static String convertMapToJson(Map map) { | |||||
| if (map == null || map.isEmpty()) { | ||||||
| return ""; | ||||||
| } | ||||||
| ObjectMapper jsonMapper = createJsonMapper(); | ||||||
| var jsonMapper = createJsonMapper(); | ||||||
| return jsonMapper.writeValueAsString(map); | ||||||
| } catch (JsonProcessingException e) { | ||||||
| throw new JsonParsingException(e); | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Creates a configured JSON {@link ObjectMapper} with indentation, disabled empty beans, and JavaTimeModule support. | ||||||
| * Creates a configured JSON {@link JsonMapper} with indentation, disabled empty beans, and JavaTimeModule support. | ||||||
| * | ||||||
| * @return the configured JSON ObjectMapper | ||||||
|
||||||
| * @return the configured JSON ObjectMapper | |
| * @return the configured JSON {@link JsonMapper} |
Copilot
AI
Dec 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc incorrectly describes the return type as 'xml ObjectMapper' when it should be 'XmlMapper'. The return type in the method signature has been updated to XmlMapper, but the Javadoc comment should reflect this more accurately.
| * @return xml mapper | |
| * @return configured {@link XmlMapper} instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is missing from commons/pom.xml. While it may be inherited from the parent, it's inconsistent with the pattern used in other module pom.xml files where the version is explicitly declared. Consider adding the version tag for consistency.