Closed
Conversation
maciejzgadzaj
force-pushed
the
payment_logs
branch
from
37483de to
a54d360
Compare
Contributor
Author
|
Result:
|
maciejzgadzaj
force-pushed
the
payment_logs
branch
from
a54d360 to
b708481
Compare
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c to
b8a7444
Compare
heddn
suggested changes
Sep 13, 2017
heddn
left a comment
heddn
left a comment
There was a problem hiding this comment.
I think the events that were added are a duplicate of the already added ones provided by state_machine. No need to add the Event and Events classes. I'll do a quick review of the rest of the patch as well.
heddn
suggested changes
Sep 13, 2017
| * The transition event. | ||
| */ | ||
| public function onAuthorizeTransition(WorkflowTransitionEvent $event) { | ||
| $this->dispatch(PaymentEvents::PAYMENT_AUTHORIZED, $event->getEntity()); |
| * The transition event. | ||
| */ | ||
| public function onVoidTransition(WorkflowTransitionEvent $event) { | ||
| $this->dispatch(PaymentEvents::PAYMENT_VOIDED, $event->getEntity()); |
| * The transition event. | ||
| */ | ||
| public function onExpireTransition(WorkflowTransitionEvent $event) { | ||
| $this->dispatch(PaymentEvents::PAYMENT_EXPIRED, $event->getEntity()); |
There was a problem hiding this comment.
And on through the rest of this subscriber...
| * bundle_plugin_type = "commerce_payment_type", | ||
| * handlers = { | ||
| * "access" = "Drupal\commerce_payment\PaymentAccessControlHandler", | ||
| * "event" = "Drupal\commerce_payment\Event\PaymentEvent", |
There was a problem hiding this comment.
I don't think this is necessary if we state_machine
Contributor
There was a problem hiding this comment.
It is, because payments do not use transitions.
Contributor
|
Closing for #797. Will make sure issues credits correct on D.o issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://www.drupal.org/node/2845321