Remove COMPLUS_* environment variable references#5714
Merged
Conversation
Co-authored-by: max-charlamb <[email protected]>
Member
|
@copilot , remove the changes to nuget.exe. This binary file should not have changed. |
…tignore Co-authored-by: max-charlamb <[email protected]>
Copilot
AI
changed the title
[WIP] Remove references to COMPLUS_* environment variables
Remove COMPLUS_* environment variable references
Feb 12, 2026
Member
|
@copilot , remove the .gitignore changes |
…fied Co-authored-by: max-charlamb <[email protected]>
Contributor
Author
Contributor
Author
noahfalk
approved these changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy COMPlus_* environment variable fallbacks/references now that the repo’s minimum supported runtime is .NET 8 and configuration is expected to use DOTNET_* prefixes.
Changes:
- Update
ProcessRunner.WithRuntimeConfigurationto only setDOTNET_{key}(dropCOMPlus_{key}fallback). - Remove the outdated .NET 6
COMPlus_prefix note from the FAQ entry aboutDOTNET_DbgMiniDumpType.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Microsoft.Diagnostics.TestHelpers/ProcessRunner.cs | Removes COMPlus_ env var fallback from runtime configuration helper. |
| documentation/FAQ.md | Updates troubleshooting guidance to remove stale COMPlus_ prefix note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| If that doesn't work, try using the `setclrpath <directory>` command with a directory that contains the matching version of the DAC module. This is useful for private runtimes or debug builds that haven't been published to our symbol servers. | ||
|
|
||
| If this is a dump, the problem could also be that the dump is missing some memory required by SOS. Try generating a "full" dump (the default with `dotnet-dump collect` without a `--type` option) or add setting the crash dump generation (createdump) environment variable `DOTNET_DbgMiniDumpType=4` (.NET 6 and below require `COMPlus_` prefix instead of `DOTNET_`). For more details on crash dump generation see [here](https://docs.microsoft.com/en-us/dotnet/core/diagnostics/dumps#collecting-dumps-on-crash). | ||
| If this is a dump, the problem could also be that the dump is missing some memory required by SOS. Try generating a "full" dump (the default with `dotnet-dump collect` without a `--type` option) or add setting the crash dump generation (createdump) environment variable `DOTNET_DbgMiniDumpType=4`. For more details on crash dump generation see [here](https://docs.microsoft.com/en-us/dotnet/core/diagnostics/dumps#collecting-dumps-on-crash). |
There was a problem hiding this comment.
The sentence is grammatically incorrect: "or add setting" should be rephrased (e.g., "or by setting" / "or set") to improve readability of the troubleshooting guidance.
mdh1418
approved these changes
Feb 12, 2026
hoyosjs
approved these changes
Feb 12, 2026
Member
|
/ba-g Unrelated test infra failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimum supported runtime is now .NET 8, so
COMPLUS_*env var fallbacks are unnecessary — all config usesDOTNET_*.ProcessRunner.WithRuntimeConfiguration: RemoveCOMPlus_fallback (the existing comment explicitly called for this)documentation/FAQ.md: Remove stale note about .NET 6 requiringCOMPlus_prefixFiles in
src/shared/(clrconfignocache.h,resource.h) are synced from dotnet/runtime and left unchanged —BFA_BAD_COMPLUS_SIGrefers to COM+ metadata signatures, not env vars.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.