Skip to content

opts: MountOpt: relax client-side validation of mount target #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvoland merged 1 commit into from
Feb 2, 2026
+0 −19
Merged

opts: MountOpt: relax client-side validation of mount target #6771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions opts/mount.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,6 @@ func (m *MountOpt) Set(value string) error {
return errors.New("type is required")
}

if mount.Target == "" {
return errors.New("target is required")
}

if mount.VolumeOptions != nil && mount.Type != mounttypes.TypeVolume {
return fmt.Errorf("cannot mix 'volume-*' options with mount type '%s'", mount.Type)
}
Expand Down
15 changes: 0 additions & 15 deletions opts/mount_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,21 +113,6 @@ func TestMountOptErrors(t *testing.T) {
doc: "empty value",
expErr: "value is empty",
},
{
doc: "missing tmpfs target",
value: "type=tmpfs",
expErr: "target is required",
},
{
doc: "missing bind target",
value: "type=bind",
expErr: "target is required",
},
{
doc: "missing volume target",
value: "type=volume,source=/foo",
expErr: "target is required",
},
{
doc: "invalid key=value",
value: "type=volume,target=/foo,bogus=foo",
Expand Down
Loading